Skip to content

ci: don't install protoc#4773

Merged
djc merged 1 commit intomainfrom
no-protoc
Mar 25, 2026
Merged

ci: don't install protoc#4773
djc merged 1 commit intomainfrom
no-protoc

Conversation

@djc
Copy link
Contributor

@djc djc commented Mar 24, 2026

@rami3l don't think we actually need it?

@djc djc marked this pull request as ready for review March 24, 2026 16:06
@djc djc requested a review from rami3l March 24, 2026 16:06
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc LGTM!

In that case maybe we should remove the description about protoc in https://rust-lang.github.io/rustup/dev-guide/tracing.html?highlight=protoc#opentelemetry-tracing as well? I remember having to install protoc locally to build the feature but that might have changed since then.

View changes since this review

@djc djc enabled auto-merge March 25, 2026 08:52
@djc
Copy link
Contributor Author

djc commented Mar 25, 2026

In that case maybe we should remove the description about protoc in https://rust-lang.github.io/rustup/dev-guide/tracing.html?highlight=protoc#opentelemetry-tracing as well? I remember having to install protoc locally to build the feature but that might have changed since then.

Removed that section.

@rami3l
Copy link
Member

rami3l commented Mar 25, 2026

To double check: no trace of protobuf being implicitly installed on GitHub Actions, so looks safe to remove. Thanks again :)

@djc djc added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 6f8931c Mar 25, 2026
29 checks passed
@djc djc deleted the no-protoc branch March 25, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants