chore: update external provider to 2.3.3

[marcoieni]

I didn't update terragrunt/modules/sync-team because I can't select an aws version. I will investigate that another time.

Note

Note that the plan in the next comment was automatically generated by running infratk plan-pr https://github.com/rust-lang/simpleinfra/pull/477 --clipboard 🎉
For now, it just runs terraform/terragrunt plan on every directory where the lockfile changes.
I plan to give a demo about the infratk tool soon

• update crates-io-prod ref

[marcoieni]

📃📃 Plan summary 📃📃

No changes detected (apply not needed):
✅ terraform/team-repo

Changes detected (apply needed):
❌ terragrunt/accounts/legacy/crates-io-prod/crates-io
❌ terragrunt/accounts/legacy/crates-io-staging/crates-io
❌ terragrunt/accounts/legacy/releases-dev/release-distribution
❌ terragrunt/accounts/legacy/releases-prod/release-distribution

📃📃 Plan output 📃📃

👉 terragrunt/accounts/legacy/crates-io-prod/crates-io:

  # fastly_service_compute.static will be updated in-place
  ~ resource "fastly_service_compute" "static" {
      ~ active_version = 39 -> (known after apply)
      ~ cloned_version = 39 -> (known after apply)
        id             = "gEfRWQihVaQqh6vsPlY0H1"
        name           = "static.crates.io"
        # (4 unchanged attributes hidden)

      ~ package {
          ~ source_code_hash = "a8881886c8461a95ef94ea2e91023dc96dcea1bebec0cdd0785c2fa4e85a32d8f41f82f9f0b96d17a17698423d9256f99803d6b2ae8019a39fc2971aa97eb437" -> "fe8edfc9d12d3429d92a31fb10010c1611581575a635ae652cda02ea5c219cee9cdcb229645bef49f8b7c09c9e72106c713d56ad2047fe947550b762f9619f19"
            # (1 unchanged attribute hidden)
        }

        # (8 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: Argument is deprecated
│ 
│   with aws_s3_bucket.index,
│   on s3-index.tf line 1, in resource "aws_s3_bucket" "index":
│    1: resource "aws_s3_bucket" "index" {
│ 
│ Use the aws_s3_bucket_versioning resource instead
│ 
│ (and 9 more similar warnings elsewhere)
╵

👉 terragrunt/accounts/legacy/crates-io-staging/crates-io:

  # fastly_service_compute.static will be updated in-place
  ~ resource "fastly_service_compute" "static" {
      ~ active_version = 95 -> (known after apply)
      ~ cloned_version = 95 -> (known after apply)
        id             = "liljrvY3Xt0CzNk0mpuLa7"
        name           = "static.staging.crates.io"
        # (4 unchanged attributes hidden)

      ~ package {
          ~ source_code_hash = "b2b550736a33231f268f0263853111e8de057026a3a193459d8202e0c4d7cd4044440c5da4e233906fb54bcae2615d65930f8f720642c69eb3978c6d14fcf52a" -> "fe8edfc9d12d3429d92a31fb10010c1611581575a635ae652cda02ea5c219cee9cdcb229645bef49f8b7c09c9e72106c713d56ad2047fe947550b762f9619f19"
            # (1 unchanged attribute hidden)
        }

        # (8 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: Argument is deprecated
│ 
│   with aws_s3_bucket.index,
│   on s3-index.tf line 1, in resource "aws_s3_bucket" "index":
│    1: resource "aws_s3_bucket" "index" {
│ 
│ Use the aws_s3_bucket_versioning resource instead
│ 
│ (and 9 more similar warnings elsewhere)
╵

👉 terragrunt/accounts/legacy/releases-dev/release-distribution:

  # fastly_service_vcl.static will be updated in-place
  ~ resource "fastly_service_vcl" "static" {
      ~ active_version     = 25 -> (known after apply)
      ~ cloned_version     = 25 -> (known after apply)
        id                 = "5qaYFyyiorVua6uCZg7It0"
        name               = "dev-static.rust-lang.org"
        # (8 unchanged attributes hidden)

      - logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }
      + logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }

      - snippet {
          - content  = <<-EOT
                if (req.url ~ "^\/rustup\/") {
                  set beresp.http.Surrogate-Key = "rustup";
                }
            EOT -> null
          - name     = "set cache key for rustup" -> null
          - priority = 100 -> null
          - type     = "fetch" -> null
        }

        # (10 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

👉 terragrunt/accounts/legacy/releases-prod/release-distribution:

  # fastly_service_vcl.static will be updated in-place
  ~ resource "fastly_service_vcl" "static" {
      ~ active_version     = 11 -> (known after apply)
      ~ cloned_version     = 11 -> (known after apply)
        id                 = "MWlq3AIDXubpbw725c7og3"
        name               = "static.rust-lang.org"
        # (8 unchanged attributes hidden)

      - logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }
      + logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }

        # (10 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[marcoieni]

The only suspicious thing in the plan is - snippet in releases-dev, but since it's "dev" I wouldn't worry too much about it.

EDIT: the snippet comes from #416

[marcoieni]

After merging #416 the snippet doesn't appear anymore. I'll apply and merge this 👍