Skip to content

Use C-unwind abi for the llvm.wasm.throw intrinsic #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

Use C-unwind abi for the llvm.wasm.throw intrinsic #1663

merged 1 commit into from
Nov 1, 2024

Conversation

@coolreader18
Copy link
Contributor

@coolreader18 coolreader18 commented Nov 1, 2024

Discovered in rust-lang/rust#132416. Before, it was outputting a nounwind attribute on unwind::wasm::_Unwind_RaiseException, which was definitely incorrect.

@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu Amanieu merged commit 9c9f4a9 into rust-lang:master Nov 1, 2024
33 checks passed
@coolreader18 coolreader18 deleted the wasm32-throw-unwindabi branch November 1, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coolreader18 @rustbot @Amanieu