Skip to content

Add AMX-AVX512 BF16 intrinsics#2089

Merged
sayantn merged 2 commits intorust-lang:mainfrom
sayantn:amx-more
Apr 21, 2026
Merged

Add AMX-AVX512 BF16 intrinsics#2089
sayantn merged 2 commits intorust-lang:mainfrom
sayantn:amx-more

Conversation

@sayantn
Copy link
Copy Markdown
Contributor

@sayantn sayantn commented Apr 19, 2026

No description provided.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 19, 2026

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, folkertdev

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 19, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev
folkertdev approved these changes Apr 19, 2026
View reviewed changes
Comment thread crates/core_arch/src/x86_64/amx.rs Outdated
#[rustc_legacy_const_generics(0)]
#[target_feature(enable = "amx-avx512,avx10.2")]
#[cfg_attr(
all(test, any(target_os = "linux", target_env = "msvc")),
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev Apr 19, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's up with windows gnu?

View changes since the review

Copy link
Copy Markdown
Contributor Author

@sayantn sayantn Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc it had some problems decoding the amx instructions, didn't check recently though. let me just check in CI once

Copy link
Copy Markdown
Contributor Author

@sayantn sayantn Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, so only apple-darwin fails now. let me reduce the conditions a bit

@sayantn sayantn added this pull request to the merge queue Apr 21, 2026
Merged via the queue into rust-lang:main with commit 0414f7c Apr 21, 2026
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees

@folkertdev folkertdev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayantn @rustbot @folkertdev