Some small overall improvements to stdarch-gen-arm#2099
Open
sayantn wants to merge 3 commits intorust-lang:mainfrom
Open
Some small overall improvements to stdarch-gen-arm#2099sayantn wants to merge 3 commits intorust-lang:mainfrom
sayantn wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
sayantn
force-pushed
the
gen-arm-improvements
branch
from
ea24450 to
2613dd9
Compare
sayantn
force-pushed
the
gen-arm-improvements
branch
from
2613dd9 to
df73ddd
Compare
Earlier patches added `big_endian_inverse` and used `transmute` instead of using `vreinterpret` due to an LLVM bug that has since been resolved
Instead of duplicating the stability attribute, re-use the `neon-stable` anchor through
Some intrinsics optimise to different instructions on big endian which leads to `assert_instr` failing
sayantn
force-pushed
the
gen-arm-improvements
branch
from
c1eb587 to
873463e
Compare
Collaborator
|
☔ The latest upstream changes (possibly #2095) made this pull request unmergeable. Please resolve the merge conflicts. |
davidtwco
approved these changes
May 5, 2026
Member
There was a problem hiding this comment.
I authored these changes so unsurprisingly they look good to me. The final commit's changes might only make sense in the context of the changes in #2063.
folkertdev
reviewed
May 5, 2026
Comment on lines
+107
to
+108
| not-big-endian: ¬-big-endian | ||
| FnCall: [not, ['target_endian = "big"']] |
Contributor
There was a problem hiding this comment.
is this better than target_endian = "small"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the edits are by @davidtwco, I have just cherry-picked it from his branch and putting the PR up.