Skip to content

intrinsic-test: run rustfmt on generated sources#2122

Merged
sayantn merged 2 commits into
rust-lang:mainfrom
davidtwco:intrinsic-test-fmt
May 20, 2026
Merged

intrinsic-test: run rustfmt on generated sources#2122
sayantn merged 2 commits into
rust-lang:mainfrom
davidtwco:intrinsic-test-fmt

Conversation

@davidtwco
Copy link
Copy Markdown
Member

This allows for simplification of the intrinsic-test generator as it no longer needs to maintain readable formatting.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 19, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, folkertdev, sayantn

@davidtwco davidtwco force-pushed the intrinsic-test-fmt branch from 0cfc142 to c24a552 Compare May 19, 2026 10:07
@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented May 19, 2026

Can we maybe do this in the intrinsic-test output, like gen-arm does?

@davidtwco davidtwco force-pushed the intrinsic-test-fmt branch from c24a552 to 3dc19da Compare May 19, 2026 10:24
@davidtwco
Copy link
Copy Markdown
Member Author

Can we maybe do this in the intrinsic-test output, like gen-arm does?

Sure, I've changed it to work that way

@davidtwco davidtwco force-pushed the intrinsic-test-fmt branch 2 times, most recently from c493194 to ec93d51 Compare May 19, 2026 11:29
davidtwco added 2 commits May 19, 2026 11:34
This allows for simplification of the intrinsic-test generator as it no
longer needs to maintain readable formatting.
This isn't necessary when rustfmt is being used to make sure the
generated sources are formatted.
@davidtwco davidtwco force-pushed the intrinsic-test-fmt branch from ec93d51 to c549681 Compare May 19, 2026 11:35
@sayantn sayantn added this pull request to the merge queue May 20, 2026
Merged via the queue into rust-lang:main with commit 391642b May 20, 2026
74 checks passed
@davidtwco davidtwco deleted the intrinsic-test-fmt branch May 20, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants