Add _mm_clflushopt intrinsic#2141
Open
jlpetz wants to merge 1 commit into
Open
Conversation
Adds the `_mm_clflushopt` intrinsic for the CLFLUSHOPT instruction (weakly-ordered cache-line flush). Until now stdarch exposed only the SSE2 `_mm_clflush`, so there was no way to emit `clflushopt` from an intrinsic. Gated on the new `clflushopt` target feature. See the PR description for the related compiler PR and tracking issue. Modeled on the existing `_mm_clflush` / `adx` intrinsics: links `llvm.x86.clflushopt`, assert_instr + simd_test coverage.
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1456: adds the
_mm_clflushoptintrinsic for theCLFLUSHOPTinstruction (weakly-ordered cache-line flush). Until now stdarchexposed only the SSE2
_mm_clflush, so there was no way to emitclflushoptfrom an intrinsic.
Gated on the
clflushopttarget feature added in rust-lang/rust#157098(tracking issue rust-lang/rust#157096). CI will be red until that compiler
change merges and syncs into the pinned toolchain here — the
#[target_feature(enable = "clflushopt")]won't be recognized before then.Modeled on the existing
_mm_clflush/adxintrinsics: linksllvm.x86.clflushopt,assert_instr(clflushopt)codegen test, and asimd_testruntime test. The Intel-verification false-match exemption for_mm_clflushis extended to cover_mm_clflushopt(both take*const u8).