Skip to content

Conversation

@yaahc
Copy link
Member

@yaahc yaahc commented Jul 12, 2023

This is in service of the first item in our backlog

  • Style team membership growth

Goals

  • Clarify what it means to be a style team member and the paths to joining our team.
    • Help new contributors get involved.
  • Help existing team members review potential members and hold them to consistent and clearly communicated expectations.

@joshtriplett
Copy link
Member

Reviewed. Thank you for working on this, @yaahc!

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all of Josh's suggestions and the proposed changes + those lgtm

yaahc and others added 3 commits August 30, 2023 11:50
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@compiler-errors
Copy link
Member

compiler-errors commented Aug 30, 2023

Action item: We decided during the meeting August 30, 2023 that @yaahc will open an FCP on this when she's cleared Josh's final comments.

note to Jane: @ rfcbot fcp merge should work on this repo, but it'll take ~20 mins for the fcp to start since rfcbot scans all of the repos in the rust-lang org.

Co-authored-by: Josh Triplett <josh@joshtriplett.org>
reorder one bullet and renumber the rest accordingly
@yaahc
Copy link
Member Author

yaahc commented Jan 24, 2024

@rfcbot fcp merge

@joshtriplett
Copy link
Member

@rfcbot reviewed

@rfcbot
Copy link

rfcbot commented Jan 24, 2024

Team member @yaahc has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@compiler-errors
Copy link
Member

@rfcbot concern four boxes

@calebcartwright
Copy link
Member

Have checked my box, should be all set now to have the concern resolved

@joshtriplett
Copy link
Member

@compiler-errors Any blockers to resolving the "four boxes" concern here? (Or, more to the point, any blockers to hitting "merge" here?)

@compiler-errors
Copy link
Member

@rfcbot resolve four boxes

Nope, no further concerns

@compiler-errors
Copy link
Member

Just needed a ping 😅

@rfcbot
Copy link

rfcbot commented May 13, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @yaahc, I wasn't able to add the final-comment-period label, please do so.

@compiler-errors
Copy link
Member

TBH I'm just gonna merge this now, given nobody except for the team probably cares what these criteria are, and that we've given this more than a year to sit.

@compiler-errors compiler-errors merged commit 52c808b into rust-lang:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants