-
Notifications
You must be signed in to change notification settings - Fork 55
Add team membership characteristics section #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add team membership characteristics section #182
Conversation
|
Reviewed. Thank you for working on this, @yaahc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all of Josh's suggestions and the proposed changes + those lgtm
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
|
Action item: We decided during the meeting August 30, 2023 that @yaahc will open an FCP on this when she's cleared Josh's final comments. note to Jane: |
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
reorder one bullet and renumber the rest accordingly
|
@rfcbot fcp merge |
|
@rfcbot reviewed |
|
Team member @yaahc has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
@rfcbot concern four boxes |
|
Have checked my box, should be all set now to have the concern resolved |
|
@compiler-errors Any blockers to resolving the "four boxes" concern here? (Or, more to the point, any blockers to hitting "merge" here?) |
|
@rfcbot resolve four boxes Nope, no further concerns |
|
Just needed a ping 😅 |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @yaahc, I wasn't able to add the |
|
TBH I'm just gonna merge this now, given nobody except for the team probably cares what these criteria are, and that we've given this more than a year to sit. |
This is in service of the first item in our backlog
Goals