Skip to content

Added zizmor CI workflow to catch future workflow issues#2412

Merged
marcoieni merged 1 commit intorust-lang:mainfrom
Sandijigs:add/zizmor-ci-workflow
Apr 15, 2026
Merged

Added zizmor CI workflow to catch future workflow issues#2412
marcoieni merged 1 commit intorust-lang:mainfrom
Sandijigs:add/zizmor-ci-workflow

Conversation

@Sandijigs
Copy link
Copy Markdown
Contributor

This PR adds a zizmor CI workflow that runs on every PR and on pushes to main, using --persona=pedantic.
Two files were added:

  1. .github/workflows/zizmor.yml : the CI workflow itself, using the official zizmorcore/zizmor-action pinned to SHA https://docs.zizmor.sh/integrations/

  2. .github/zizmor.yml :config file that tells zizmor to skip findings that were already reviewed and accepted as unfixable in Fixed zizmor pedantic findings across workflow files #2409
    https://docs.zizmor.sh/configuration/

I used ignore in the config so these rules are skipped for the specific files listed.

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions
Copy link
Copy Markdown

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

Copy link
Copy Markdown
Contributor

@ubiratansoares ubiratansoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great!

A small request : we should opt-out from Github Advanced Security for now. Could you please adjust the zizmor job? There is an input to control this option.

@Sandijigs Sandijigs force-pushed the add/zizmor-ci-workflow branch from 4bc01e8 to 4420efe Compare April 14, 2026 19:42
@Sandijigs Sandijigs closed this Apr 14, 2026
@Sandijigs
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @ubiratansoares . I've set advanced-security: false in the zizmor action inputs.

@marcoieni
Copy link
Copy Markdown
Member

maybe you closed the PR by mistake when force pushing?

@Sandijigs
Copy link
Copy Markdown
Contributor Author

Sandijigs commented Apr 15, 2026

I think I closed it by mistake , I would go ahead and reopen it

@Sandijigs Sandijigs reopened this Apr 15, 2026
Copy link
Copy Markdown
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🙌

@marcoieni marcoieni added this pull request to the merge queue Apr 15, 2026
Merged via the queue into rust-lang:main with commit 51a4e92 Apr 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants