-
Notifications
You must be signed in to change notification settings - Fork 330
Enable syncing for Zulip #t-docs-rs/private
#2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| [[zulip-groups]] | ||
| name = "T-docs-rs" | ||
|
|
||
| [[zulip-streams]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works a bit differently. The channel should only be included in one file (here), but it should have:
extra-teams = [
"infra",
]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, thanks!
|
Seems like we can't have two teams invited into a private stream? EDIT: |
1ce699b to
4c8d442
Compare
|
I saw @walterhpearce is in the stream, too. So this PR will remove him probably. |
|
we could add him with the |
|
Who are they? |
|
Walter works at the rust foundation as a security engineer |
|
Oh I see. Why aren't they part of the infra team? Would make things simpler. :) |
|
Less work for me is always welcome 😁 My hope is that the project creates a dedicated security team one day :) |
|
That would be convenient! Well, adding them in the meantime. |
4c8d442 to
a4017ef
Compare
Dry-run check results |
|
Here is the diff: so consider adding back some of these zulip accounts if you think they should be there! |
Enable syncing for Zulip `#t-docs-rs/private`
|
Most of them were former members of the docs.rs team (sadness 😿), so I think it's as expected. They can still ask us to be brought back on the channel if needed. |
So based on #2075, we need to invite rust-lang-owner to the stream first.
Since we also want to have the infra team to have access to this channel, I added them as well.
cc @syphar