Triagebot labels parsing case insensitive

[apiraino]

I wouldn't mind the triagebot being able to parse label in a case insensitive way (but I don't remember if this was already discussed).

Screenshotting my lazyness

If there are no opposing opinions, I can have a look at this.

[Mark-Simulacrum]

Wouldn't this require looking up and/or caching all labels that exist on a repository? I don't think GitHub has case insensitive APIs...

I don't object to doing that, but let's be careful to avoid a bunch of API calls per label, it's probably not worth it to spend that much rate limit and time budget.

[apiraino]

ahh you're right, everytime we add a label we check if it exists.

However it seems that GH understands casing 🤔 and will refuse to create labels (as documented in the triagebot code):

# these works
curl -H $TOKEN https://api.github.com/repos/rust-lang/triagebot/issues/1915/labels -d '{"labels":["bug","Bug"]}'
curl -H $TOKEN 'https://api.github.com/repos/rust-lang/rust/labels/P-high'
curl -H $TOKEN 'https://api.github.com/repos/rust-lang/rust/labels/p-high'

# this returns 404
curl -H $TOKEN  'https://api.github.com/repos/rust-lang/rust/labels/mark'

[apiraino]

I wonder if we could trust this behaviour and add all labels in a blow, instead of iterating and running multiple HTTP queries

[ehuss]

GitHub documents that it is case-insensitive.

The problem is this line which needs to be case-insensitive check.

[apiraino]

ah ok thanks! ok, then closing - at least now we have a trace about why it's easier to keep labels checks case sensitive

[ehuss]

I'm not sure I understand why this was closed. I was pointing out that there is a very trivial line to change to make it case-insensitive.

[apiraino]

Sorry, I mistakenly taken the wording in your comment as a blocker for a patch changing this behaviour, rather than a hint about where to touch the code.

Since Github seems to understand what it is meant when sending any variation of an existing label, I might have a look at this, provided it doesn't end up doing bookkeeping (as Mark hints).

@rustbot claim