Make timestamps visually uncopyable and simplify the impl #2199
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
reviewed
Oct 11, 2025
Urgau
force-pushed
the
gha-logs-better-uncopy
branch
from
54cad7a to
afd212f
Compare
Member
|
Cool solution. |
Kobzol
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves #2198 by making the timestamps visually unselect-able/uncopyable.
This is done by putting the timestamps in a "floating"
::beforeelement, which has the consequence of making the element actually uncopyable.This also simplifies the implementation of our copy event by removing the timestamps removal as they are no longer select-able. This also as the advantage that partial selection of a timestamp does not leave it in the copy.