Skip to content

Avoid trailing new-lines between each line of the table in our GHA logs viewer #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Avoid trailing new-lines between each line of the table in our GHA logs viewer #2224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
175e923
Avoid trailing new-lines between each line of the table
Urgau Nov 2, 2025
b330745
Avoid new-lines before and after our `<table>` to take effect
Urgau Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/gha_logs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,11 @@ body {{
font: 14px SFMono-Regular, Consolas, Liberation Mono, Menlo, monospace;
background: #0C0C0C;
color: #CCC;
}}
table {{
white-space: pre;
table-layout: fixed;
width: 100%;
}}
.timestamp {{
color: #848484;
Expand Down Expand Up @@ -275,14 +279,14 @@ body {{
html = html.replace(/^\uFEFF/gm, "");

// 3. Transform each log lines that doesn't start with a timestamp into a row where everything is in the second column
const untsRegex = /^(?!\d{{4}}-\d{{2}}-\d{{2}}T\d{{2}}:\d{{2}}:\d{{2}}\.\d+Z)(.*)$/gm;
const untsRegex = /^(?!\d{{4}}-\d{{2}}-\d{{2}}T\d{{2}}:\d{{2}}:\d{{2}}\.\d+Z)(.*)(\r?\n)?/gm;
html = html.replace(untsRegex, (match, log) =>
`<tr><td></td><td>${{log}}</td></tr>`
);

// 3.b Transform each log lines that start with a timestamp in a row with two columns and make the timestamp be a
// self-referencial anchor.
const tsRegex = /^(\d{{4}}-\d{{2}}-\d{{2}}T\d{{2}}:\d{{2}}:\d{{2}}\.\d+Z) (.*)$/gm;
const tsRegex = /^(\d{{4}}-\d{{2}}-\d{{2}}T\d{{2}}:\d{{2}}:\d{{2}}\.\d+Z) (.*)(\r?\n)?/gm;
html = html.replace(tsRegex, (match, ts, log) =>
`<tr><td><a id="${{ts}}" href="#${{ts}}" class="timestamp">${{ts}}</a></td><td>${{log}}</td></tr>`
);
Expand Down Expand Up @@ -358,7 +362,7 @@ body {{
</script>
</head>
<body>
<table style="table-layout: fixed; width: 100%">
<table>
<colgroup>
<col style="width: 29ch">
<col style="width: 100%">
Expand Down
Loading