Drop Weak<WaitableNativeActivityState> in on_destroy#237
Merged
Conversation
When we know we're done with the `Weak` reference that is associated with the `NativeActivity` callbacks we make sure to drop the `Weak` reference so that the underlying allocation for the `WaitableNativeActivityState` can be freed. This also updates `try_with_waitable_activity_ref` to be more careful about converting the `Weak` ref back into a raw pointer _before_ calling the handler, just in case the handler triggers a panic and unwinds (where we wouldn't want to lose/Drop our weak ref).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we know we're done with the
Weakreference that is associated with theNativeActivitycallbacks we make sure to drop theWeakreference so that the underlying allocation for theWaitableNativeActivityStatecan be freed.This also updates
try_with_waitable_activity_refto be more careful about converting theWeakref back into a raw pointer before calling the handler, just in case the handler triggers a panic and unwinds (where we wouldn't want to lose/Drop our weak ref).