Add From<IpAddr> impls for AddressFamily and NeighbourAddress #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-dude
approved these changes
Nov 24, 2025
cathay4t
approved these changes
Nov 25, 2025
When writing AF-agnostic code it's convenient to get the appropriate AddressFamily variant for a given IpAddr. Since all platform variations of AddressFamily have Inet and Inet6 variants, we add the impl in a platform-agnostic manner. Signed-off-by: Duncan Eastoe <duncan@graphiant.com>
There are already impls for Ipv4Addr and Ipv6Addr, so for convenience and commonality with other *Address types add an impl for IpAddr too. Signed-off-by: Duncan Eastoe <duncan@graphiant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing AF-agnostic code it's convenient to get the appropriate
AddressFamily variant for a given IpAddr.
Since all platform variations of AddressFamily have Inet and Inet6
variants, we add the impl in a platform-agnostic manner.
There are already impls for Ipv4Addr and Ipv6Addr, so for convenience
and commonality with other *Address types add an impl for IpAddr too.