Skip to content

upgrade env_logger to 0.11#38

Merged
cathay4t merged 2 commits intorust-netlink:mainfrom
alexanderkjall:upgrade-env-logger-to-0.11
Mar 31, 2026
Merged

upgrade env_logger to 0.11#38
cathay4t merged 2 commits intorust-netlink:mainfrom
alexanderkjall:upgrade-env-logger-to-0.11

Conversation

@alexanderkjall
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the env_logger dev-dependency from version 0.8.2 to 0.11. Feedback indicates that this major version jump likely introduces breaking changes that require corresponding code updates to ensure the project remains buildable.

Comment thread Cargo.toml

[dev-dependencies]
env_logger = "0.8.2"
env_logger = "0.11"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading env_logger from version 0.8.2 to 0.11 is a major version jump that spans multiple breaking releases. For instance, env_logger v0.9.0 and v0.10.0 introduced significant breaking changes to the builder API and module structure.

Since there are no corresponding code changes in this PR to adapt to these new versions, it's highly likely that this will break tests or examples that rely on env_logger.

It is strongly recommended to also include the necessary code updates for the new env_logger version in this pull request to ensure the project remains buildable.

@cathay4t
Copy link
Copy Markdown
Member

I will fix the CI in another PR.

@cathay4t cathay4t enabled auto-merge (rebase) March 31, 2026 08:21
@cathay4t cathay4t merged commit 1ed6084 into rust-netlink:main Mar 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants