link: vxlan: add localbypass support#166
Conversation
Intrduced support for the VXLAN localbypass attribute, which controls whether the VXLAN localbypass mode is turned on. This is equivalent to `ip link add name NAME type vxlan id VNI [no]localbypass`. Signed-off-by: Gris Ge <cnfourt@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the localbypass attribute to VXLAN link messages by implementing a new method in the LinkMessageBuilder. The reviewer suggested using standard Rust doc comments (///) for the new method to ensure proper documentation generation and recommended adding a unit test to verify the serialization of the new attribute.
| self.append_info_data(InfoVxlan::CollectMetadata(collect_metadata)) | ||
| } | ||
|
|
||
| // Adds the `localbypass` attribute to the VXLAN |
There was a problem hiding this comment.
The documentation comment for localbypass starts with // instead of ///. In Rust, /// is the standard prefix for doc comments that are parsed by rustdoc. Using // will prevent this line from appearing in the generated documentation.
| // Adds the `localbypass` attribute to the VXLAN | |
| /// Adds the localbypass attribute to the VXLAN |
References
- In Rust, /// is the standard prefix for doc comments that are parsed by rustdoc. (link)
| /// This is equivalent to `ip link add name NAME type vxlan id VNI | ||
| /// [no]localbypass`. \[no\]localbypass - specifies if the VXLAN | ||
| /// localbypass mode is turned on. | ||
| pub fn localbypass(self, localbypass: bool) -> Self { |
There was a problem hiding this comment.
Consider adding a unit test in src/link/test.rs to verify that the localbypass attribute is correctly serialized into the netlink message. While there are currently no VXLAN-specific tests in that file, adding one for this new feature would improve code quality and help prevent regressions.
1 participant
Intrduced support for the VXLAN localbypass attribute, which controls
whether the VXLAN localbypass mode is turned on.
This is equivalent to
ip link add name NAME type vxlan id VNI [no]localbypass.