Remove an unreachable endianness bug in mac_digit#343
Merged
cuviper merged 2 commits intorust-num:masterfrom Apr 21, 2026
Merged
Remove an unreachable endianness bug in mac_digit#343cuviper merged 2 commits intorust-num:masterfrom
mac_digit#343cuviper merged 2 commits intorust-num:masterfrom
Conversation
This code wrongly created a `[hi, lo]` array to add its final carry digit, when that should be little-endian `[lo, hi]`. However, this was dead code because `mac_with_carry` always shifts `>> BITS`, so the `carry` value **never** has high bits at this point. We'll keep a debug assertion for that, but otherwise it's safe to assume.
Member
Author
|
AFAICT this bug was introduced in #141, but it was unreachable even then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code wrongly created a
[hi, lo]array to add its final carry digit, when that should be little-endian[lo, hi]. However, this was dead code becausemac_with_carryalways shifts>> BITS, so thecarryvalue never has high bits at this point. We'll keep a debug assertion for that, but otherwise it's safe to assume.