Provide idiomatic abstraction for vGPU type information#68
Merged
swlynch99 merged 2 commits intorust-nvml:mainfrom Jun 10, 2025
christoph-heiss:vgpu-types
Merged
Provide idiomatic abstraction for vGPU type information#68swlynch99 merged 2 commits intorust-nvml:mainfrom christoph-heiss:vgpu-types
swlynch99 merged 2 commits intorust-nvml:mainfrom
christoph-heiss:vgpu-types
Conversation
Contributor
Author
|
Ping. Is this of any interest for this library? |
Contributor
|
@christoph-heiss Thanks for the ping. A bit of background is that we (IOP Systems) became the primary maintainer of this repo earlier this year, after the original owner took a job that made it tricky for them to contribute to OSS. This PR was submitted before we came on board, and fell through the crack a bit during this transition. We will take a look and hopefully get it merged soon. |
swlynch99
reviewed
Apr 23, 2025
Contributor
Author
|
Thanks for the review! I've fixed both nits. |
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
Contributor
|
I'm gonna go ahead and merge this as it's been a few months and the code LGTM. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty straight forward overall. Introduces a new
VgpuTypestruct, which wraps over anvmlVgpuTypeId_tand a proper idiomatic way to access these informations.I'v also added a
Nvml::lib()method, for accessing the underlying (raw) library from the abstraction. This would be useful for e.g. calling functions which are not yet abstracted innvml-wrapper, without having to completely usenvml-wrapper-sysand NIH, basically. Hopefully that is acceptable.