variety of fixes for warnings in new rust #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this locking code may not be strictly sound (creates multiple |
|
Yeah the locking callbacks are only used in EOL versions of OpenSSL so when we drop support for those it should all go away. |
sfackler
reviewed
Jul 2, 2025
| @@ -1,3 +1,8 @@ | |||
| #
There was a problem hiding this comment.
I'd be fine doing that now imo, but doesn't matter too much either way.
There was a problem hiding this comment.
I'm also fine bumping the MSRV (cryptography's is now 1.74 without incident), but I'm trying to only do one thing 😂
sfackler
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.