Add support for RSDP tags #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phil-opp
reviewed
May 5, 2018
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Looks good to me, it just seems like there's one field missing for RsdpV2Tag.
| _rsdt_address: u32, | ||
| length: u32, | ||
| xsdt_address: u64, // This is the PHYSICAL address of the XSDT | ||
| _reserved: [u8; 3], |
Member
There was a problem hiding this comment.
There should be an extended_checksum field before _reserved, shouldn't it?
Closed
Contributor
|
Yeah I think there should |
Member
Author
|
🤦 fixed. Would you like this squashed, or is it fine as-is? |
xacrimon
approved these changes
May 5, 2018
Contributor
xacrimon
left a comment
xacrimon
left a comment
There was a problem hiding this comment.
I think it'll be fine without a squash.
Contributor
|
Ready to merge Isaac |
Member
Author
|
Awesome, but I don't have write access, so could someone who does do the actual merge? |
Contributor
|
@phil-opp Could you give Isaac write access? I'll be doing this merge. |
Contributor
|
Merged |
Member
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for tags for reading the address of the RSDP, a structure used in ACPI. There are two different structs, one for ACPI Version 1.0, the other for subsequent versions. It also adds tests to the grub2 test.