Switch/configure is_valid query?

[wseaton]

Hello, I have a legacy database that I'm looking to use r2d2-postgres w/ (Teiid) that implements a PostgreSQL compatible API. Unfortunately it doesn't support passing in blank queries as described by the PostgreSQL spec.

Debugging thread here: sfu-db/connector-x#107

Would you be open to switching the probe query for is_valid to something more standard, like SELECT 1;, or at least make this configurable? This would allow me (and others) to retain connection pooling functionality in that case.

I noticed SELECT 1; is actually what is recommended upstream in r2d2 for connection pool implementors, and understand the empty query is probably slightly faster round trip.

Thanks!

[sfackler]

Sure, SELECT 1 seems reasonable to me.

[wseaton]

@sfackler now that this is merged, do you have plans to cut a patch release?

[sfackler]

Done!