Replace util_libc and sanitizer modules with impl_utils macro
#763
+185
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
changed the title
util_libc with impl_utils macroutil_libc and sanitizer with impl_utils macro
newpavlov
changed the title
util_libc and sanitizer with impl_utils macroutil_libc and sanitizer modules with impl_utils macro
newpavlov
commented
Dec 3, 2025
| (get_errno) => { | ||
| cfg_if! { | ||
| if #[cfg(any(target_os = "netbsd", target_os = "openbsd", target_os = "android", target_os = "cygwin"))] { | ||
| use libc::__errno as errno_location; |
Member
Author
There was a problem hiding this comment.
Technically, we could move these imports into backends, but I think it will result in a more convoluted and harder to review code.
Contributor
There was a problem hiding this comment.
personal opinion: that would be better
tamird
reviewed
Dec 3, 2025
| (get_errno) => { | ||
| cfg_if! { | ||
| if #[cfg(any(target_os = "netbsd", target_os = "openbsd", target_os = "android", target_os = "cygwin"))] { | ||
| use libc::__errno as errno_location; |
Contributor
There was a problem hiding this comment.
personal opinion: that would be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #760