Bump versions + Edition 2018 + Pcg64#823
Conversation
This avoids a circular dependency between rand and rand_distr
Note: benchmarks now show different results to mentioned for fill_bytes impl, possibly because of #[inline] changes
|
What's the motivation for using the |
|
Looks good otherwise. I don't understand the test failures on Linux beta and stable: |
|
Just because we can and some users may expect it to be just I don't understand the failure either. Of course, we know those examples don't work with |
|
Note: I can fix the examples to work without #[cfg(feature = "std")]
let mut rng = rand::thread_rng();
#[cfg(not(feature = "std"))] // no support for thread_rng
let mut rng = <rand::rngs::StdRng as rand::SeedableRng>::seed_from_u64(0); |
Note: Cargo patch was used since rand_os dependend on rdrand on sgx. Now getrandom has its own rdrand impl.
I think this might be problematic if there is a |
|
Yes, and that's precisely why I didn't document it (due to the way optional deps show up as features, one should never consider an undocumented feature a stable part of the API IMO). But you may be right that it's better simply not to implement |
|
Reverted and pushed version bump for next RC |
This combines a few things because we need a new minor version for several crates, hence:
serde support is now available with either theserdeorserde1feature for most of these, excludingrand_isaac(which requiresrand_core'sserde1), though doc still says useserde1Pcg64(been on my to-do list a while)