rand: Remove serde1 feature#830
Conversation
This feature does not do anything in the `rand` crate and was forwarded to `rand_core`, where it was used for `BlockRng` and `BlockRng64`. However, crates using this feature would use `rand_core` directly instead, making the feature pointless for `rand`. It is not expected to use this feature for any of the RNGs in `rand`. This hopefully makes it possible to build `rand` on docs.rs again. (See rust-lang/docs.rs#369.) Now the serde1 feature does not do anything, but it is still available for backwards compatibility.
- `rand_xoshiro` should be built with the feature. - For `rand`, it does not do anything. Instead, test it for `rand_core`.
|
The failures seem to be due to "store build cache" timing out on Travis. |
|
You're right that we don't need to pass this to I think the only reason we might want this is if we enabled serialisation for |
I don't think it makes sense to enable it for |
This feature does not do anything in the
randcrate and was forwardedto
rand_core, where it was used forBlockRngandBlockRng64.However, crates using this feature would use
rand_coredirectlyinstead, making the feature pointless for
rand.It is not expected to use this feature for any of the RNGs in
rand.This hopefully makes it possible to build
randon docs.rs again.(See rust-lang/docs.rs#369.)
Now the serde1 feature does not do anything, but it is still available
for backwards compatibility.