Utils for word generators #29
Closed
+294
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
commented
Nov 24, 2025
Comment on lines
-123
to
-135
| /// Implement `next_u32` via `fill_bytes`, little-endian order. | ||
| pub fn next_u32_via_fill<R: RngCore + ?Sized>(rng: &mut R) -> u32 { | ||
| let mut buf = [0; 4]; | ||
| rng.fill_bytes(&mut buf); | ||
| u32::from_le_bytes(buf) | ||
| } | ||
|
|
||
| /// Implement `next_u64` via `fill_bytes`, little-endian order. | ||
| pub fn next_u64_via_fill<R: RngCore + ?Sized>(rng: &mut R) -> u64 { | ||
| let mut buf = [0; 8]; | ||
| rng.fill_bytes(&mut buf); | ||
| u64::from_le_bytes(buf) | ||
| } |
Member
Author
There was a problem hiding this comment.
These have no replacement, but are rarely (if ever: getrandom doesn't use them) needed, so removal is fine.
Member
Author
|
I like the new helpers slightly more than what we did have. The question is whether we want to introduce trait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Subset of #24 for non-block generators (essentially I copied and cut all the block stuff).
Motivation
I found #24 difficult to review: too large and I'm not 100% convinced we should drop the
blockcode.Details
Documentation is tweaked slightly.