Remove never crate and switch to Infallible type#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atom_syndicationcurrently uses the never crate to provide a stable bottom/never type (!) while we wait for!to be stabilised. This is a library that appears essentially unmaintained (not that it's too much of a problem - not much code to maintain!), and has been deleted from the original repo (the upstream link in crates.io is a dead link to a file in the Fuchsia monorepo)atom_syndicationis only using thenever::Nevertype to indicate an error, which the Rust standard library already provides in the form ofInfallible. This is currently an empty struct with some trait implementations (much likenever::Never), but upon stabilisation of!will be switched to a type alias. With a couple exceptions, this is forward compatible. We can switch toInfallibleand drop a dependency.This makes my work a little easier as I'm currently packaging a dependent of
atom_syndication, and by extension,atom_syndicationitself, in the Fedora repos, andneverhas some license file weirdness which is a PITA.