Remove unwraps in vhost-device-scmi #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsso
force-pushed
the
patch-1
branch
2 times, most recently
from
00ceb4d to
d2a8aea
Compare
A few unwraps which may or may not be needed was replaced with Result types. Signed-off-by: Fredrik Simonsson <fredrsim@axis.com>
epilys
requested changes
May 15, 2025
vhost-device-scmi/src/main.rs
Outdated
| } | ||
|
|
||
| let backend = Arc::new(RwLock::new(backend_instance.unwrap())); | ||
| let backend = Arc::new(RwLock::new(backend_instance.map_err(|e| format!("{e}"))?)); |
Member
There was a problem hiding this comment.
format!("{e}") is unnecessary for types that implement std::fmt::Display, simply do:
map_err(|err| err.to_string())
Author
There was a problem hiding this comment.
I used the same code as other places in the file, I changed all of them now.
mz-pdm
reviewed
May 15, 2025
Signed-off-by: Fredrik Simonsson <fredrsim@axis.com>
added 2 commits
May 15, 2025 16:57
Signed-off-by: Fredrik Simonsson <fredrsim@axis.com>
Signed-off-by: Fredrik Simonsson <fredrsim@axis.com>
Signed-off-by: Fredrik Simonsson <fredrsim@axis.com>
mz-pdm
approved these changes
May 16, 2025
epilys
approved these changes
May 16, 2025
Member
|
Thank you so much @simonsso! |
Member
|
Oops, I just realized the commits were not squashed together before merging. My bad, apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Remove panics with proper errors.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.