Implement redraw requested 2.0#1332
Merged
Merged
Conversation
Contributor
Author
|
@goddessfreya hey could you double-check that Wayland is still functioning properly? I'm pretty sure I rebased this correctly, but I'd like to be 100% sure before it's merged. |
Contributor
|
Gave X11 and Wayland both a quick test (in i3 and weston, respectively) and they both appear to be functioning as intended (everything is arriving in order and all). Is there something specific you want me to test for? |
Osspial
force-pushed
the
redraw-requested-2.0-rebased
branch
from
d96041e to
ddd71db
Compare
* Implement changes to `RedrawRequested` event Implements the changes described in #1041 for the X11 platform and for platform-independent public-facing code. * Fix `request_redraw` example * Fix examples in lib docs * Only issue `RedrawRequested` on final `Expose` event
* Move event loop runner to runner module * Implement new redraw API
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
* Implement revamped `RedrawRequested` on Web * Add `web` example
* Implement revamped `RedrawRequested` on iOS * Added RedrawEventsCleared to events_cleared logic * Fixed from comments * Added RedrawEventsCleared to draw_rect handler. * Fixed out of order `RedrawEventsCleared` events. * cargo fmt
Fix window_run_return Make docs build
Osspial
force-pushed
the
redraw-requested-2.0-rebased
branch
from
ddd71db to
8a9a9cd
Compare
Contributor
Author
|
@goddessfreya nah, just wanted a quick sanity check. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1082.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersI'm mainly opening this as a PR for clerical reasons and to make reviewing the diff easier; it should be merged manually, so the individual commits don't get squished together. Thank you to everyone that helped with writing code, giving feedback, reviewing, and shepherding this process along.
🎉