win32: fix WM_TASKBARCREATED deadlock#4563
Open
Invades wants to merge 1 commit intorust-windowing:masterfrom
Open
win32: fix WM_TASKBARCREATED deadlock#4563Invades wants to merge 1 commit intorust-windowing:masterfrom
Invades wants to merge 1 commit intorust-windowing:masterfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersFixes a Win32 UI-thread deadlock when handling the registered
TaskbarCreatedmessage.The handler previously held
window_state_lock()while callingset_skip_taskbar(...). That call can synchronously re-enter the same window proc through Win32, and the re-entered path can try to acquire the same window state lock again, deadlocking the UI thread.This copies
skip_taskbarout of the window state first, so the lock is dropped before callingset_skip_taskbar(...).No changelog/docs/example added because this is an internal Win32 deadlock fix with no user-facing API or behavior change beyond avoiding the hang.