fix(mobile): deeplink, disable by default#14824
Conversation
Signed-off-by: fufesou <linlong1266@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded runtime gating for deep links on Android/iOS by checking configuration options Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR mitigates reported mobile deep link CVEs by disabling sensitive rustdesk:// deep link actions (server config import and permanent password overwrite) by default, only allowing them when explicitly enabled via built-in options.
Changes:
- Added new built-in option keys to control whether deep links can modify server settings or permanent password.
- Gated handling of
rustdesk://config/...andrustdesk://password/...on Android/iOS behind those options, rejecting and showing a generic failure toast when disabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flutter/lib/consts.dart | Introduces built-in option keys for deep link enablement. |
| flutter/lib/common.dart | Enforces mobile deep link allowlist checks for config and password authorities with rejection behavior when disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
#14576
2.3 Zero-Click Password Overwrite via Deep Linkand2.6 Zero-Click Infrastructure Hijack (rustdesk://config/)in https://docs.google.com/document/d/e/2PACX-1vSds6jjpd38oO_yIAyd1HYtKNUuea-I-ozAPpGhYI7QgAU-QGJ7D8a4rOZVj1vmiUXV1EcdRHf9aZAW/pubCVE-2026-30793
CVE-2026-30797
CVE-2026-30791
Summary by CodeRabbit