test(s3): cover select no-such-key fallback#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes a remaining regression gap in the recent S3 Select fallback classification coverage.
When an S3-compatible backend fails to return structured error metadata,
crates/s3/src/select.rsfalls back to matching known error substrings in the response text. TheNoSuchKeybranch in that fallback logic is part of the current runtime behavior, but it was still untested after the recent Select coverage additions.This patch adds one focused unit test for the metadata-missing
NoSuchKeypath. Runtime behavior is unchanged.Root Cause
Recent Select follow-up PRs covered serialization helpers, exit codes,
AccessDenied, andNotImplementedfallback handling, but they did not exercise theNoSuchKeysubstring fallback that maps missing-object responses toNotFound.Validation
cargo test -p rc-s3 classify_missing_code_maps_no_such_key_substring --libmake pre-commit