Skip to content

test(s3): cover select no-such-key fallback#156

Merged
overtrue merged 1 commit intomainfrom
codex/test-s3-select-nosuchkey-fallback
Apr 28, 2026
Merged

test(s3): cover select no-such-key fallback#156
overtrue merged 1 commit intomainfrom
codex/test-s3-select-nosuchkey-fallback

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

Summary

This PR closes a remaining regression gap in the recent S3 Select fallback classification coverage.

When an S3-compatible backend fails to return structured error metadata, crates/s3/src/select.rs falls back to matching known error substrings in the response text. The NoSuchKey branch in that fallback logic is part of the current runtime behavior, but it was still untested after the recent Select coverage additions.

This patch adds one focused unit test for the metadata-missing NoSuchKey path. Runtime behavior is unchanged.

Root Cause

Recent Select follow-up PRs covered serialization helpers, exit codes, AccessDenied, and NotImplemented fallback handling, but they did not exercise the NoSuchKey substring fallback that maps missing-object responses to NotFound.

Validation

  • cargo test -p rc-s3 classify_missing_code_maps_no_such_key_substring --lib
  • make pre-commit

@overtrue overtrue marked this pull request as ready for review April 28, 2026 05:12
@overtrue overtrue merged commit 801fbd0 into main Apr 28, 2026
15 checks passed
@overtrue overtrue deleted the codex/test-s3-select-nosuchkey-fallback branch April 28, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant