Skip to content

fix(ls): honor --versions listings#162

Merged
overtrue merged 2 commits intomainfrom
codex/fix-ls-versions-issue-159
Apr 29, 2026
Merged

fix(ls): honor --versions listings#162
overtrue merged 2 commits intomainfrom
codex/fix-ls-versions-issue-159

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

Summary

  • fix rc ls --versions to list object versions instead of falling back to the normal object listing path
  • keep JSON output under the existing items envelope and include version metadata for each returned entry
  • add an integration regression test that uploads two versions of the same object and verifies both are returned

Related Issue

Root Cause

LsArgs exposed --versions, but crates/cli/src/commands/ls.rs never used the flag and always called the regular object listing path.

Validation

  • cargo fmt --all --check
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace
  • TEST_S3_ENDPOINT=http://127.0.0.1:19000 TEST_S3_ACCESS_KEY=accesskey TEST_S3_SECRET_KEY=secretkey cargo test -p rustfs-cli --features integration test_ls_versions_lists_multiple_object_versions -- --nocapture

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9abb1ae519

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/cli/src/commands/ls.rs Outdated
Comment thread crates/cli/src/commands/ls.rs Outdated
@overtrue overtrue merged commit acd01d3 into main Apr 29, 2026
15 checks passed
@overtrue overtrue deleted the codex/fix-ls-versions-issue-159 branch April 29, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rc does not support displaying multiple versions.

1 participant