Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9abb1ae519
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc ls --versionsto list object versions instead of falling back to the normal object listing pathitemsenvelope and include version metadata for each returned entryRelated Issue
Root Cause
LsArgsexposed--versions, butcrates/cli/src/commands/ls.rsnever used the flag and always called the regular object listing path.Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceTEST_S3_ENDPOINT=http://127.0.0.1:19000 TEST_S3_ACCESS_KEY=accesskey TEST_S3_SECRET_KEY=secretkey cargo test -p rustfs-cli --features integration test_ls_versions_lists_multiple_object_versions -- --nocapture