Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion crates/s3/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1736,9 +1736,11 @@ impl ObjectStore for S3Client {
.send()
.await
.map_err(|e| {
let err_str = e.to_string();
let err_str = Self::format_sdk_error(&e);
if err_str.contains("NotFound") || err_str.contains("NoSuchBucket") {
Error::NotFound(format!("Bucket not found: {bucket}"))
} else if err_str.contains("BucketNotEmpty") {
Error::Conflict(err_str)
} else {
Error::Network(err_str)
}
Expand Down Expand Up @@ -3528,6 +3530,54 @@ mod tests {
}
}

#[tokio::test]
async fn delete_bucket_maps_bucket_not_empty_to_conflict() {
let response = http::Response::builder()
.status(409)
.header("x-amz-error-code", "BucketNotEmpty")
.body(SdkBody::from(
r#"<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>BucketNotEmpty</Code>
<Message>The bucket you tried to delete is not empty.</Message>
</Error>"#,
))
.expect("build delete bucket response");
let (client, _request_receiver) = test_s3_client(Some(response));

let result = client.delete_bucket("bucket").await;

match result {
Err(Error::Conflict(message)) => assert!(message.contains("BucketNotEmpty")),
other => panic!("Expected Conflict for non-empty bucket, got: {other:?}"),
}
}

#[tokio::test]
async fn delete_bucket_maps_missing_bucket_to_not_found() {
let response = http::Response::builder()
.status(404)
.header("x-amz-error-code", "NoSuchBucket")
.body(SdkBody::from(
r#"<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>NoSuchBucket</Code>
<Message>The specified bucket does not exist.</Message>
</Error>"#,
))
.expect("build missing bucket response");
let (client, _request_receiver) = test_s3_client(Some(response));

let result = client.delete_bucket("missing-bucket").await;

match result {
Err(Error::NotFound(message)) => {
assert_eq!(message, "Bucket not found: missing-bucket")
}
other => panic!("Expected NotFound for missing bucket, got: {other:?}"),
}
}

#[tokio::test]
async fn delete_objects_with_force_delete_sets_rustfs_header() {
let response = http::Response::builder()
Expand Down