Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions crates/cli/tests/env_alias.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,44 @@ fn alias_list_rejects_invalid_rc_host_percent_encoding_without_credentials() {
assert_eq!(payload["details"]["type"], "usage_error");
}

#[test]
fn alias_list_rejects_invalid_rc_host_access_key_percent_encoding_without_credentials() {
let config_dir = tempfile::tempdir().expect("create config dir");

let output = Command::new(rc_binary())
.args(["alias", "list", "--json"])
.env("RC_CONFIG_DIR", config_dir.path())
.env(
"RC_HOST_badalias",
"https://ACCESS%ZZKEY:SECRET_KEY@rustfs.local:9000",
)
.output()
.expect("run rc command");

assert_eq!(
output.status.code(),
Some(2),
"stdout: {}\nstderr: {}",
String::from_utf8_lossy(&output.stdout),
String::from_utf8_lossy(&output.stderr)
);

let stderr = String::from_utf8(output.stderr).expect("stderr should be UTF-8");
assert!(!stderr.contains("ACCESS"));
assert!(!stderr.contains("SECRET_KEY"));

let payload: serde_json::Value = serde_json::from_str(&stderr).expect("JSON error output");
assert!(
payload["error"]
.as_str()
.expect("error message")
.contains("invalid percent-encoding in access key"),
"payload: {payload}"
);
assert_eq!(payload["code"], 2);
assert_eq!(payload["details"]["type"], "usage_error");
}

#[test]
fn alias_list_rejects_invalid_rc_host_scheme_without_credentials() {
let config_dir = tempfile::tempdir().expect("create config dir");
Expand Down
11 changes: 11 additions & 0 deletions crates/core/src/alias.rs
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,17 @@ mod tests {
assert!(!error.contains("SECRET"));
}

#[test]
fn test_parse_rc_host_alias_rejects_invalid_access_key_percent_encoding() {
let result = parse_env_alias("invalid", "https://ACCESS%ZZKEY:SECRET_KEY@rustfs.local");

assert!(result.is_err());
let error = result.unwrap_err().to_string();
assert!(error.contains("invalid percent-encoding in access key"));
assert!(!error.contains("ACCESS"));
assert!(!error.contains("SECRET_KEY"));
}

#[test]
fn test_env_aliases_from_vars_filters_rc_host_prefix() {
let aliases = env_aliases_from_vars(vec![
Expand Down
Loading