test(s3): cover custom XML request headers#206
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage in the S3 client unit tests to ensure user-provided custom x-amz-* request headers are applied to the manually-signed XML request path (used by replication/bucket ops) and included in the SigV4 signed header list.
Changes:
- Added a small local TCP capture server to record raw XML HTTP requests (method/target/headers).
- Added a unit test asserting custom headers are present on XML requests and appear in the
Authorizationsigned headers list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c705e99 to
5ded438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
None.
Background
Recent custom request header support covered AWS SDK requests and presigned URL behavior, but the manually signed XML request path used by bucket replication and related operations did not have direct regression coverage.
Solution
Add a focused S3 client unit test with a local HTTP capture server. The test verifies that custom x-amz headers are sent on XML requests and included in the Authorization signed header list.
Test status