Skip to content

test(cli): cover object remove purge help contract#94

Merged
overtrue merged 1 commit intomainfrom
codex/object-remove-purge-help-gap
Apr 19, 2026
Merged

test(cli): cover object remove purge help contract#94
overtrue merged 1 commit intomainfrom
codex/object-remove-purge-help-gap

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

@overtrue overtrue commented Apr 8, 2026

Summary

This change adds a focused help-contract test for the noun-first rc object remove command. The recent rm --purge work changed the shared remove argument surface, but the help-contract suite only covered the legacy rc rm entrypoint and did not verify that the noun-first alias exposed the same option set.

Problem

Users can reach object deletion through both rc rm and rc object remove. Because object remove reuses RmArgs, option changes such as --purge should remain discoverable through both entrypoints. Without a contract test on the noun-first command, a future clap wiring or command-group change could silently drop or alter that help surface while the existing rm help test still passed.

Fix

The test suite now asserts the rc object remove --help usage line, the inherited delete options, and a representative example. The new case includes --purge, which ties the test directly to the recent remove-command change while keeping the scope limited to help-contract coverage.

Validation

I could not run make pre-commit because this repository does not contain a Makefile or a pre-commit target. I ran the equivalent required checks from the repository instructions instead:

  • cargo fmt --all --check
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace

@overtrue overtrue marked this pull request as ready for review April 19, 2026 14:53
@overtrue overtrue merged commit 4d5cb5e into main Apr 19, 2026
15 checks passed
@overtrue overtrue deleted the codex/object-remove-purge-help-gap branch April 19, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant