Skip to content

fix: handle control character object keys#139

Merged
overtrue merged 1 commit into
mainfrom
overtrue/fix-control-char-object-keys
Jun 21, 2026
Merged

fix: handle control character object keys#139
overtrue merged 1 commit into
mainfrom
overtrue/fix-control-char-object-keys

Conversation

@overtrue

@overtrue overtrue commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Fix object listing for keys containing XML-invalid control characters by requesting URL-encoded S3 listing responses and decoding keys before UI/delete flows consume them. Also repairs the malformed lockfile document and formats the ESLint config so project checks pass.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
CI=true pnpm install --frozen-lockfile --prefer-offline
pnpm tsc --noEmit
pnpm lint
pnpm format:check
node --test tests/lib/s3-object-encoding.test.ts

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Closes #138

Screenshots (if applicable)

N/A

Additional Notes

The repository does not currently define a test:run script; the added regression test was run directly with Node.

@overtrue overtrue merged commit aa47d8a into main Jun 21, 2026
10 checks passed
@overtrue overtrue deleted the overtrue/fix-control-char-object-keys branch June 21, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] web控制台无法处理带控制字符的 object key

1 participant