Skip to content

Conversation

@overtrue
Copy link
Collaborator

📝 Pull Request

📋 Description

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Code refactoring
  • ⚡ Performance improvement
  • 🧪 Test improvements
  • 🔒 Security fix

🧪 Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Performance tests added/updated
  • Manual testing completed

Test Results

# 运行测试的命令和结果
npm run test

📊 Performance Impact

  • No performance impact
  • Performance improved
  • Performance impact analyzed and acceptable
  • Performance benchmarks included

🔒 Security Considerations

  • No security impact
  • Security review completed
  • Vulnerability assessment done
  • Security tests added

📚 Documentation

  • Code comments updated
  • README updated (if needed)
  • API documentation updated (if needed)
  • Changelog updated

✅ Checklist

Code Quality

  • Code follows the project's style guidelines
  • Self-review of the code completed
  • Code is properly commented
  • No console.log or debug statements left
  • TypeScript types are properly defined

Testing

  • All existing tests pass
  • New tests cover the changes
  • Test coverage is maintained or improved
  • Edge cases are tested

Dependencies

  • No new dependencies added, or they are justified
  • Dependencies are up to date
  • No security vulnerabilities in dependencies

Compatibility

  • Changes are backward compatible
  • Browser compatibility maintained
  • Node.js version compatibility maintained

🔗 Related Issues

Closes #
Fixes #
Related to #

📸 Screenshots (if applicable)

Before After

🚀 Deployment Notes

  • No special deployment steps required
  • Database migration required
  • Configuration changes required
  • Environment variables updated

👥 Reviewers

Please review: @

📝 Additional Notes


🤖 Automated Checks

The following checks will be automatically performed:

  • ✅ Code formatting (Prettier)
  • ✅ Type checking (TypeScript)
  • ✅ Linting (ESLint)
  • ✅ Unit tests
  • ✅ Integration tests
  • ✅ Security scan
  • ✅ Performance tests
  • ✅ Build verification

📊 Code Coverage

Current coverage will be displayed here after the tests run.

⚡ Performance Benchmarks

Performance impact will be analyzed and displayed here.

…cn-vue-i7qnxy

refactor: migrate events management ui to shadcn
overtrue and others added 29 commits October 26, 2025 22:49
- Enhance bucket-selector component to auto-load bucket list
- Add bucket prefix display in selected value (e.g., '存储桶: bucket-name')
- Remove separate Label component, prefix now shown in selector value
- Update all pages (events, lifecycle, replication) to use refactored component
- Fix type errors: accept string | null for bucketName prop in form components
- Migrate pages/events/index.vue to use DataTable
- Migrate pages/license/index.vue feature permissions table to DataTable
- Migrate components/user/* tables to DataTable (account, policies, groups)
- Migrate components/user-group/* tables to DataTable (policies, members, set-policies-mutiple)
- Replace native table elements and raw Table components with shared DataTable
- Implement search functionality using DataTable filter capabilities
- Ensure consistent table rendering across the application
- 移除 149 个测试相关的翻译键(应该/should 开头的测试描述)
- 移除测试数据相关的键(folder%test 等)
- 移除函数性能测试相关的键
- 更新 AGENTS.md,添加语言包处理规则:排除测试目录
- 确保三个语言包的键保持一致(847 个键)
- 重构 data-table 组件,统一使用 enableRowSelection 启用选择功能
- 统一使用 shadcn-vue Checkbox 组件,确保 UI 一致性
- 重构 object/list.vue,移除手动实现的选择列,使用标准方案
- 提取 UserSelector 组件,支持多选和自定义标签
- 修复 lifecycle/replication/events 组件的 bucketName 类型安全问题
- 简化 useDataTable 接口,移除未使用的方法
- 优化 data-table.vue,减少代码重复
- 移除冗余导入和未使用的文件
- 修复 lib/api-client.ts 中在类方法中直接调用 composables 的问题
- 添加 ApiErrorHandler 错误处理器,通过依赖注入方式处理 401 错误
- 创建路由工具函数 utils/routes.ts,统一管理路由路径
- 修复 composables/useAuth.ts 中的硬编码路径,使用工具函数
- 修复 components/copy-input.vue 的生命周期问题,在 onMounted 中创建 ClipboardJS 实例
- 修复 plugins/03.s3.ts 中的错误处理,使用 navigateTo 替代直接操作 window.location
- 修复 pages/config.vue 中的硬编码路径
- 添加 composables/useFormValidation.ts、useAsyncOperation.ts、useErrorHandler.ts 工具函数(供后续使用)
- 添加 types/api.ts 类型定义
- Translate all Chinese comments in new composables and utilities to English
- Add missing translation keys to language packs (en-US, zh-CN, tr-TR):
  - Validation failed
  - API request failed
  - Operation failed
- Ensure all code comments follow English convention
- Translate Chinese comments in Vue components
- Translate Chinese comments in composables
- Translate Chinese comments in utils and lib modules
- Translate Chinese comments in store modules
- Translate documentation strings in config-helpers.ts
- Maintain code accuracy and readability
- Translate all Chinese content in tests/README.md to English
- Rewrite main README.md with accurate project information
- Update tech stack versions (Nuxt 4, Node.js 22+, pnpm)
- Add detailed project structure documentation
- Improve deployment and contribution guidelines
- Add comprehensive testing documentation references
@overtrue overtrue merged commit 715e7fa into main Oct 31, 2025
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants