Skip to content

Conversation

@overtrue
Copy link
Collaborator

  • Add checkbox to toggle showing deleted objects
  • Update UI layout to include search and show deleted option
  • Add i18n translations for 'Show Deleted Objects' in en-US, tr-TR, and zh-CN

📝 Pull Request

📋 Description

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Code refactoring
  • ⚡ Performance improvement
  • 🧪 Test improvements
  • 🔒 Security fix

🧪 Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Performance tests added/updated
  • Manual testing completed

Test Results

# 运行测试的命令和结果
npm run test

📊 Performance Impact

  • No performance impact
  • Performance improved
  • Performance impact analyzed and acceptable
  • Performance benchmarks included

🔒 Security Considerations

  • No security impact
  • Security review completed
  • Vulnerability assessment done
  • Security tests added

📚 Documentation

  • Code comments updated
  • README updated (if needed)
  • API documentation updated (if needed)
  • Changelog updated

✅ Checklist

Code Quality

  • Code follows the project's style guidelines
  • Self-review of the code completed
  • Code is properly commented
  • No console.log or debug statements left
  • TypeScript types are properly defined
  • All commit messages are in English (following Conventional Commits)

Testing

  • All existing tests pass
  • New tests cover the changes
  • Test coverage is maintained or improved
  • Edge cases are tested

Dependencies

  • No new dependencies added, or they are justified
  • Dependencies are up to date
  • No security vulnerabilities in dependencies

Compatibility

  • Changes are backward compatible
  • Browser compatibility maintained
  • Node.js version compatibility maintained

🔗 Related Issues

Closes #
Fixes #
Related to #

📸 Screenshots (if applicable)

Before After

🚀 Deployment Notes

  • No special deployment steps required
  • Database migration required
  • Configuration changes required
  • Environment variables updated

👥 Reviewers

Please review: @

📝 Additional Notes


🤖 Automated Checks

The following checks will be automatically performed:

  • ✅ Code formatting (Prettier)
  • ✅ Type checking (TypeScript)
  • ✅ Linting (ESLint)
  • ✅ Unit tests
  • ✅ Integration tests
  • ✅ Security scan
  • ✅ Performance tests
  • ✅ Build verification

📊 Code Coverage

Current coverage will be displayed here after the tests run.

⚡ Performance Benchmarks

Performance impact will be analyzed and displayed here.

- Add checkbox to toggle showing deleted objects
- Update UI layout to include search and show deleted option
- Add i18n translations for 'Show Deleted Objects' in en-US, tr-TR, and zh-CN
- Add rule to always run pnpm run lint:fix after code changes
- Format components/object/list.vue to comply with Prettier
@codecov
Copy link

codecov bot commented Nov 20, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

- Add pnpm overrides to force glob >=10.5.0 (fixes high severity command injection)
- Add pnpm overrides to force js-yaml >=4.1.1 (fixes moderate severity prototype pollution)
- Update pnpm-lock.yaml with secure dependency versions
@overtrue overtrue merged commit 974ef11 into main Nov 20, 2025
12 checks passed
@overtrue overtrue deleted the feat-include-deleted-objects branch November 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants