Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the installation documentation to use new default ports (9000/9001), replaces the TOML-based observability configuration with environment variables, and enhances the Docker guide with more complete docker run examples.
- Change default RustFS service and console ports from 7000/7001 to 9000/9001
- Migrate observability config from
/etc/default/obs.tomltoexportvariables - Add full Docker run command examples and parameter explanations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/zh/installation/linux.md | Updated ports, switched observability to environment vars, refined systemd service settings |
| docs/zh/installation/docker.md | Switched examples from Podman to Docker, updated ports, added full docker run snippets |
Comments suppressed due to low confidence (4)
docs/zh/installation/linux.md:168
$current_dirisn’t defined earlier in the guide. Recommend clarifying how to set this variable or using an absolute path for consistency.
export RUSTFS_OBS_LOG_DIRECTORY="$current_dir/deploy/logs" # Log directory
docs/zh/installation/docker.md:77
- The mount for the configuration file was removed, which prevents RustFS from loading its config. Re-add
-v /etc/rustfs/rustfs:/config/rustfs:roor update the example to show where the config lives.
-v /mnt/rustfs/data:/data \
docs/zh/installation/linux.md:215
- By removing
$RUSTFS_OPTS, users lose the ability to pass custom flags. Consider restoringExecStart=/usr/local/bin/rustfs $RUSTFS_VOLUMES $RUSTFS_OPTSor documenting how to supply extra options.
ExecStart=/usr/local/bin/rustfs \$RUSTFS_VOLUMES
docs/zh/installation/docker.md:73
- [nitpick] This line has an extra leading space before
docker. Align indentation with other command lines for consistent formatting.
docker run -d \
| -e RUSTFS_CONSOLE_ENABLE=true \ | ||
| -e RUSTFS_SERVER_DOMAINS=example.com \ | ||
| rustfs/rustfs:latest \ | ||
| ./target/debug/rustfs \ |
There was a problem hiding this comment.
Specifying ./target/debug/rustfs inside the container assumes a locally built binary that may not exist. Use the container’s default entrypoint or ensure the path is valid inside the image.
| ./target/debug/rustfs \ |
| docker pull docker://rustfs/rustfs | ||
|
|
There was a problem hiding this comment.
[nitpick] Using docker:// syntax is non-standard for Docker CLI. Recommend simplifying to docker pull rustfs/rustfs or docker pull quay.io/rustfs/rustfs.
| docker pull docker://rustfs/rustfs | |
| docker pull rustfs/rustfs |
No description provided.