Skip to content

improve code for docker install#2

Merged
houseme merged 1 commit intomainfrom
fix/install
Jul 8, 2025
Merged

improve code for docker install#2
houseme merged 1 commit intomainfrom
fix/install

Conversation

@houseme
Copy link
Copy Markdown
Contributor

@houseme houseme commented Jul 8, 2025

No description provided.

@houseme houseme requested review from Copilot and overtrue July 8, 2025 15:07
@houseme houseme merged commit ec6fa0c into main Jul 8, 2025
@houseme houseme deleted the fix/install branch July 8, 2025 15:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the installation documentation to use new default ports (9000/9001), replaces the TOML-based observability configuration with environment variables, and enhances the Docker guide with more complete docker run examples.

  • Change default RustFS service and console ports from 7000/7001 to 9000/9001
  • Migrate observability config from /etc/default/obs.toml to export variables
  • Add full Docker run command examples and parameter explanations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/zh/installation/linux.md Updated ports, switched observability to environment vars, refined systemd service settings
docs/zh/installation/docker.md Switched examples from Podman to Docker, updated ports, added full docker run snippets
Comments suppressed due to low confidence (4)

docs/zh/installation/linux.md:168

  • $current_dir isn’t defined earlier in the guide. Recommend clarifying how to set this variable or using an absolute path for consistency.
export RUSTFS_OBS_LOG_DIRECTORY="$current_dir/deploy/logs" # Log directory

docs/zh/installation/docker.md:77

  • The mount for the configuration file was removed, which prevents RustFS from loading its config. Re-add -v /etc/rustfs/rustfs:/config/rustfs:ro or update the example to show where the config lives.
  -v /mnt/rustfs/data:/data \

docs/zh/installation/linux.md:215

  • By removing $RUSTFS_OPTS, users lose the ability to pass custom flags. Consider restoring ExecStart=/usr/local/bin/rustfs $RUSTFS_VOLUMES $RUSTFS_OPTS or documenting how to supply extra options.
ExecStart=/usr/local/bin/rustfs \$RUSTFS_VOLUMES

docs/zh/installation/docker.md:73

  • [nitpick] This line has an extra leading space before docker. Align indentation with other command lines for consistent formatting.
 docker run -d \

-e RUSTFS_CONSOLE_ENABLE=true \
-e RUSTFS_SERVER_DOMAINS=example.com \
rustfs/rustfs:latest \
./target/debug/rustfs \
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying ./target/debug/rustfs inside the container assumes a locally built binary that may not exist. Use the container’s default entrypoint or ensure the path is valid inside the image.

Suggested change
./target/debug/rustfs \

Copilot uses AI. Check for mistakes.
Comment on lines +42 to 43
docker pull docker://rustfs/rustfs

Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using docker:// syntax is non-standard for Docker CLI. Recommend simplifying to docker pull rustfs/rustfs or docker pull quay.io/rustfs/rustfs.

Suggested change
docker pull docker://rustfs/rustfs
docker pull rustfs/rustfs

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants