Update deps, improve perf/A11y/SEO and resolve errors#54
Update deps, improve perf/A11y/SEO and resolve errors#54overtrue merged 5 commits intorustfs:mainfrom
Conversation
chore: remove unused @heroicons/react
|
@nakrovati is attempting to deploy a commit to the overtrue's projects Team on Vercel. A member of the Team first needs to authorize it. |
nakrovati
force-pushed
the
refactor/update-deps-and-improve-perf
branch
from
58c571d to
359c726
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58c571d93d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export default function LinkTwitter({ className, size = 'size-4' }: { className?: string | string[], size?: string }) { | ||
| return ( | ||
| <Link className={cn('inline-block text-muted-foreground hover:text-primary', className)} href="https://x.com/rustfsofficial"> | ||
| <Link className={cn('inline-block text-muted-foreground hover:text-primary', className)} href="https://x.com/rustfsofficial" aria-label="RustFS Twitter" target="_blank"> |
There was a problem hiding this comment.
This link now uses target="_blank" but does not set rel="noopener noreferrer", which allows the external page to access window.opener and potentially navigate the original tab. Because this change explicitly introduced opening x.com in a new tab, the missing rel is a newly introduced security regression for users clicking the Twitter link.
Useful? React with 👍 / 👎.
components/ui/globe.tsx
Outdated
| <div | ||
| className={cn( | ||
| "absolute inset-0 mx-auto aspect-[1/1] w-full max-w-[600px]", | ||
| "absolute inset-0 mx-auto aspect-squarwe w-full max-w-[600px]", |
There was a problem hiding this comment.
The class name aspect-squarwe is not a valid Tailwind utility, so the container no longer gets an aspect-ratio rule. This removes the square constraint that previously ensured consistent globe sizing and can lead to stretched or unstable canvas dimensions depending on parent layout. Replacing it with aspect-square (or the previous aspect-[1/1]) restores intended rendering.
Useful? React with 👍 / 👎.
2 participants
@heroicons/react- it's not being used