simple deployment via docker-compose #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Mehraji <a.mehraji75@gmail.com>
Signed-off-by: Ali Mehraji <a.mehraji75@gmail.com>
|
|
cod3mas0n
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a simplified Docker Compose deployment configuration and fixes a critical volume syntax bug in the existing docker-compose.yml.
- Corrects volume path expansion syntax from
{0..3}to{0...3}in docker-compose.yml - Adds docker-compose-simple.yml for minimal RustFS deployment with object caching enabled
- Includes a volume permission fixer service to handle ownership for multiple volumes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker-compose.yml | Fixes volume syntax from {0..3} to {0...3} (two dots to three dots) for proper path expansion in RUSTFS_VOLUMES environment variable |
| docker-compose-simple.yml | Adds new simplified Docker Compose configuration with RustFS, Redis (optional via profile), in-memory object cache enabled, and init container for volume permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- object caching is in memory - remove redis service and volumes Signed-off-by: Ali Mehraji <a.mehraji75@gmail.com>
Contributor
Author
|
@houseme Let me know if you need refactoring of the main |
Contributor
|
/LGTM /cc @houseme |
houseme
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.in volumes indocker-compose.ymlin Define 4 storage volumes environment.docker-compose-simple.ymlto deploy RustFS alongside Redis cache for objects without any observability and proxy services (profiles).RUSTFS_OBJECT_CACHE_TTL_SECS=300andRUSTFS_OBJECT_CACHE_ENABLE=truecache envs for the new docker-compose.volume-permission-helper.Summary of Changes
Add a simple Docker Compose file without any proxy and observability profiles.
Checklist
make pre-commitAdditional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.