fix(iam): STS parent groups fallback and session policy debug for #1423#1804
Merged
overtrue merged 3 commits intorustfs:mainfrom Feb 14, 2026
Merged
Conversation
loverustfs
approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where temporary credentials created via AssumeRole fail to properly evaluate group-attached policies because AssumeRole does not copy groups from the parent user. The fix implements a fallback mechanism to use the parent user's groups when the temporary credential has no groups assigned.
Changes:
- Added groups fallback logic in
is_allowed_ststo use parent user's groups when temp credentials have none - Added debug logging to track session policy evaluation flow for diagnosing AccessDenied errors
GatewayJ
force-pushed
the
fix/issue-1423-sts-session-policy
branch
from
da68661 to
d1ac194
Compare
…tfs#1423 - Use parent user's groups for policy_db_get when temp credential has no groups, so group-attached policies apply (AssumeRole does not copy groups). - Add debug logging in is_allowed_sts for session policy evaluation (action, has_session_policy, is_allowed_sp, parent_user) to diagnose vendored-credential AccessDenied (e.g. DeleteObjects 403).
GatewayJ
force-pushed
the
fix/issue-1423-sts-session-policy
branch
from
d1ac194 to
681e4cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.