refactor(admin): route tier config manager through AppContext#1959
Merged
overtrue merged 1 commit intorustfs:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors tier configuration management to route through AppContext instead of direct global access, continuing the P5-02 convergence initiative started in PR #1958. The changes introduce a new TierConfigInterface boundary in the application context layer and update all tier admin handlers to use it.
Changes:
- Added
TierConfigInterfacetoAppContextwith default adapter that wrapsGLOBAL_TierConfigMgr - Replaced all direct
GLOBAL_TierConfigMgrreads/writes in tier admin handlers with AppContext-based access via helper function - Removed direct global import from tier handler module while maintaining identical external API behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rustfs/src/app/context.rs | Added TierConfigInterface trait, TierConfigHandle adapter, integrated into AppContext struct and initialization |
| rustfs/src/admin/handlers/tier.rs | Added tier_config_mgr_from_context() helper, updated all 7 operations (Add/Edit/List/Remove/Verify/GetInfo/Clear) to use context-based access, removed GLOBAL_TierConfigMgr import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
TierConfigInterfaceinAppContextwith default adapter to centralize tier-config dependency access.GLOBAL_TierConfigMgrreads/writes inadmin/handlers/tier.rswith AppContext-based access.Checklist
make pre-commitImpact
Additional Notes
make pre-commit(fmt/clippy/check/test).P5-02convergence step after PR refactor(app): converge lower-priority global reads via AppContext #1958.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.