Skip to content

test(admin): cover heal alias routes#2329

Merged
overtrue merged 1 commit into
mainfrom
codex/test-heal-admin-alias-routes
Mar 30, 2026
Merged

test(admin): cover heal alias routes#2329
overtrue merged 1 commit into
mainfrom
codex/test-heal-admin-alias-routes

Conversation

@overtrue
Copy link
Copy Markdown
Collaborator

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Test/CI
  • Performance Improvement
  • Refactor
  • Other:

Related Issues

N/A

Summary of Changes

This PR closes a narrow coverage gap in the admin compatibility route tests for the recent heal compatibility work. The existing alias-contract test verified MinIO-compatible admin aliases for several endpoints, but it did not register the heal routes and therefore did not exercise the newly added heal alias paths at all.

The change updates rustfs/src/admin/route_registration_test.rs to register heal routes in the alias test and assert the MinIO-compatible aliases for root heal, bucket heal, prefix heal, and background-heal status. This keeps the test scope aligned with the recent routing change and gives reviewers a direct regression signal if compatibility coverage is lost.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:
    Adds focused regression coverage for MinIO-compatible heal admin routes.

Additional Notes

Verification performed locally:

  • cargo test -p rustfs test_admin_alias_paths_match_existing_admin_routes -- --nocapture
  • make pre-commit

The targeted test failed before the setup/assertion update because the alias-contract test never registered heal routes, which left the recent compatibility paths untested.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@overtrue overtrue marked this pull request as ready for review March 29, 2026 13:25
Copilot AI review requested due to automatic review settings March 29, 2026 13:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Closes a coverage gap in the admin compatibility route tests by ensuring MinIO-compatible “heal” alias routes are registered and asserted in the existing alias-contract test.

Changes:

  • Registers heal admin routes in the alias-path compatibility test setup.
  • Adds assertions for MinIO-compatible alias paths covering root heal, bucket heal, prefix heal, and background-heal status.

@overtrue overtrue force-pushed the codex/test-heal-admin-alias-routes branch from 5b41466 to f02469d Compare March 29, 2026 19:24
@overtrue overtrue merged commit 74b2c70 into main Mar 30, 2026
7 checks passed
@overtrue overtrue deleted the codex/test-heal-admin-alias-routes branch March 30, 2026 12:11
houseme added a commit that referenced this pull request Mar 30, 2026
…argets

* 'main' of github.com:rustfs/rustfs:
  test(ecstore): cover read offset overflow (#2341)
  test(ecstore): cover inline bitrot offset reads (#2337)
  test(admin): cover heal alias routes (#2329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants