test(admin): cover heal alias routes#2329
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Closes a coverage gap in the admin compatibility route tests by ensuring MinIO-compatible “heal” alias routes are registered and asserted in the existing alias-contract test.
Changes:
- Registers
healadmin routes in the alias-path compatibility test setup. - Adds assertions for MinIO-compatible alias paths covering root heal, bucket heal, prefix heal, and background-heal status.
5b41466 to
f02469d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
N/A
Summary of Changes
This PR closes a narrow coverage gap in the admin compatibility route tests for the recent heal compatibility work. The existing alias-contract test verified MinIO-compatible admin aliases for several endpoints, but it did not register the heal routes and therefore did not exercise the newly added heal alias paths at all.
The change updates
rustfs/src/admin/route_registration_test.rsto register heal routes in the alias test and assert the MinIO-compatible aliases for root heal, bucket heal, prefix heal, and background-heal status. This keeps the test scope aligned with the recent routing change and gives reviewers a direct regression signal if compatibility coverage is lost.Checklist
make pre-commitImpact
Adds focused regression coverage for MinIO-compatible heal admin routes.
Additional Notes
Verification performed locally:
cargo test -p rustfs test_admin_alias_paths_match_existing_admin_routes -- --nocapturemake pre-commitThe targeted test failed before the setup/assertion update because the alias-contract test never registered heal routes, which left the recent compatibility paths untested.
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.