ci: force Node.js 24 for JS setup actions#2424
Merged
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
heihutu
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s GitHub Actions CI configuration to opt JavaScript-based setup actions into running on Node.js 24 (to avoid Node.js 20 deprecation warnings) and pins the FlatBuffers compiler setup action to a specific version.
Changes:
- Pin
.github/actions/setuptoNugine/setup-flatc@v1.2.4. - Add
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"at the job level in CI workflows that invoke the setup composite action. - Remove reliance on step-level Node-forcing env (per PR intent) by centralizing the opt-in at workflow job level.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/performance.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for performance jobs using the setup action. |
| .github/workflows/ci.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for CI jobs using the setup action. |
| .github/workflows/build.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for the build job using the setup action. |
| .github/actions/setup/action.yml | Pins Nugine/setup-flatc to v1.2.4 within the composite setup action. |
Comment on lines
62
to
66
| repo-token: ${{ inputs.github-token }} | ||
|
|
||
| - name: Install flatc | ||
| uses: Nugine/setup-flatc@v1 | ||
| uses: Nugine/setup-flatc@v1.2.4 | ||
| with: |
There was a problem hiding this comment.
The PR description mentions removing a step-level Node-forcing env from this composite action, but this diff only changes the Nugine/setup-flatc ref. If the env removal was intended, it looks missing from the PR; otherwise please update the PR description to match what actually changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Nugine/setup-flatctov1.2.4in.github/actions/setup/action.yml.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24settings and centralize it as job-level environment variables.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=trueto jobs that use the composite setup action:ci.yml:test-and-lint,build-rustfs-debug-binarybuild.yml:build-rustfsperformance.yml:performance-profile,benchmarkChecklist
make pre-commitImpact
Additional Notes
arduino/setup-protoc@v3in place (latest available isv3.0.0) and opts actions into Node.js 24 via runner flag.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.