Skip to content

fix(oidc): add federated logout flow#2667

Merged
GatewayJ merged 2 commits intomainfrom
codex/oidc-federated-logout-rustfs
Apr 24, 2026
Merged

fix(oidc): add federated logout flow#2667
GatewayJ merged 2 commits intomainfrom
codex/oidc-federated-logout-rustfs

Conversation

@cxymds
Copy link
Copy Markdown
Member

@cxymds cxymds commented Apr 24, 2026

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Summary of Changes

  • add an OIDC logout endpoint that consumes a one-time logout token and redirects either to the IdP end-session URL or back to the console login page
  • persist one-time logout sessions in the IAM OIDC state store instead of exposing raw ID tokens to browser storage
  • include the logout token in the console callback fragment and cover the new route/fragment behavior with targeted tests

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:
    Enables console-side OIDC federated logout when the provider exposes end_session_endpoint, with a safe fallback when it does not.

Additional Notes

Targeted verification run locally:

  • cargo test -p rustfs-iam test_logout_state_store_insert_and_take
  • PROTOC=/opt/homebrew/Cellar/protobuf@29/29.4/bin/protoc cargo test -p rustfs test_is_oidc_path_includes_logout
  • PROTOC=/opt/homebrew/Cellar/protobuf@29/29.4/bin/protoc cargo test -p rustfs test_build_console_callback_fragment_includes_logout_token
  • PROTOC=/opt/homebrew/Cellar/protobuf@29/29.4/bin/protoc cargo test -p rustfs test_register_routes_cover_representative_admin_paths
  • cargo fmt --check --all

@github-actions
Copy link
Copy Markdown
Contributor

CLA requirements are satisfied for this pull request.

@cxymds cxymds requested a review from GatewayJ April 24, 2026 03:27
@GatewayJ GatewayJ added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 8d4caea Apr 24, 2026
8 checks passed
@GatewayJ GatewayJ deleted the codex/oidc-federated-logout-rustfs branch April 24, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants