fix(admin): map IAM not found errors to 404#2685
Merged
overtrue merged 2 commits intorustfs:mainfrom Apr 26, 2026
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Fixes #2681
Summary of Changes
Admin handlers previously wrapped IAM not-found errors as
InternalError, which made s3s serialize missing users, groups, policies, and service accounts as HTTP 500 responses.This change adds a shared IAM-to-S3 error mapper for admin handlers and maps IAM not-found variants to
NoSuchKey, which s3s serializes as HTTP 404. Existing non-not-found IAM failures remainInternalError.The affected group, user, policy, and service account admin paths now return a 404-class response for missing IAM resources so clients can avoid retrying user input errors as server failures.
Checklist
make pre-commitVerification:
git diff --checkpassed.cargo fmt --all --checkpassed.cargo test -p rustfs --lib admin::handlerspassed: 221 passed, 0 failed, 1 ignored.make pre-commitwas not run per requester instruction.Impact
Missing IAM resources on affected admin endpoints now return HTTP 404 instead of HTTP 500.
Additional Notes
Non-not-found IAM errors are still treated as internal server errors.
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.