feat: add features option to build script#2834
Merged
Merged
Conversation
e.g. build-rustfs.sh --features webdav Signed-off-by: giter <giter@users.noreply.github.com>
Contributor
|
CLA requirements are satisfied for this pull request. |
houseme
approved these changes
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the top-level build-rustfs.sh build helper to allow callers (e.g., CI or local developers) to enable Cargo features via a new --features / -f CLI option when building the rustfs binaries.
Changes:
- Added a
FEATURESoption and surfaced it in--helpoutput and example invocations. - Appended
--features <value>to the constructed Cargo build command when provided. - Printed selected features in the build configuration summary output.
Comment on lines
+447
to
+449
| if [ -n "$FEATURES" ]; then | ||
| build_cmd+=" --features $FEATURES" | ||
| fi |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: 安正超 <anzhengchao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. build-rustfs.sh --features webdav
Related Issues
Summary of Changes
Verification
Impact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.